How to fix the current problem of bows hitting 100% of the time

from Elemental Forums

I posted this in Heavenfall's bigfix thread, but figured I would post it here too.

Create a file called Whateverthehellyouwant.xml and stick thees lines in there:

Code: xml
  3. <?xml version="1.0" encoding="iso-8859-1"?>
  4. <Spells>
  5.  <DataChecksum NoParse="1">
  6.   <Ignore>DisplayName,Description,IconFG,IconBG,IconColor,SoundFX,ParticleEffect,EffectScale</Ignore>
  7.   <Translate>DisplayName,Description</Translate>
  8.  </DataChecksum>
  10. <SpellDef InternalName="BasicBowAttack">
  12. <GameModifier InternalName="ArrowDamage">
  14. <Calculate InternalName = "MinValue">
  15.   <Expression><![CDATA[[Value]*.2]]></Expression>
  16.    </Calculate>
  17.    <Calculate InternalName = "MaxValue">
  18.      <Expression><![CDATA[[Value]*1]]></Expression>
  19.    </Calculate>
  20.     </GameModifier>
  22. </SpellDef>
  24. </Spells>

 You can mess around with the numbers if you like. It's fairly straigtforward. But this will at least generate a range of damage instead of 100%.

 

4,557 views 8 replies
Reply #1 from Elemental Forums Top

Thanks. Saves me from messing with it.

Now if we could get armour working right, and change combat from my side goes/your side goes to one of my guys goes/one of your guys goes/repeat, combat might actually be fun again. I hope with Python we can really adjust the flow and parameters used in combat along with other things. B)

Reply #2 from Elemental Forums Top

do we have to do this for all bows?

 

Elemental: Reforged
Reply #3 from Elemental Forums Top

Quoting EviliroN, reply 2
do we have to do this for all bows?

 
End of EviliroN's quote

 

No.  This is the SpellDef that ALL bows use.  Just fix it in one place.

Reply #4 from Elemental Forums Top

No, this effects the ranges attack ability (spelldef) that all bows have. Probably need one for the catapults too.

Reply #5 from Elemental Forums Top

I'm looking at the xml and I'm thinking to myself: there is NO WAY this can work in-game.

Reply #6 from Elemental Forums Top

I was editing the firebreath ranged attack (there are 3, this one, bows and catapults in RangedAttackSpells.xml)

It was different of the rest of things, whose  code I checked. I needed the base value to be positive or I would miss all the time. Having ValueOwner in multiple clauses, caused the max damage bug (in this case it didn't matter if the value was positive or negative).

Working tested code part for the damage:

Code: xml
  3. <Calculate InternalName = "Value" ValueOwner="CastingUnit">
  4.  <Expression><![CDATA[[UnitStat_Attack]*1]]></Expression>
  5. </Calculate>
  7. <Calculate InternalName = "MinValue">
  8. <Expression><![CDATA[0.5*[Value]]]></Expression>
  9. </Calculate>
  10. <Calculate InternalName = "MaxValue">
  11. <Expression><![CDATA[1*[Value]]]></Expression>
  12. </Calculate>

 

Hope this helps someone.

Reply #7 from Elemental Forums Top

lol, looks like forum formats smiles inside xml

Reply #8 from Elemental Forums Top

LOL, I would swear that wasn't there before xDD

bugs in the forum?

 

Her'es the full code that has been tested and works, the partial solution from initial post didn't work for me, although it should. Needed to correct the negative base damage again.

 

Code: xml
  3. <?xml version="1.0" encoding="iso-8859-1"?>
  4. <Spells>
  5. <DataChecksum NoParse="1">
  6. <Ignore>DisplayName,Description,IconFG,IconBG,IconColor,SoundFX,ParticleEffect,EffectScale</Ignore>
  7. <Translate>DisplayName,Description</Translate>
  8. </DataChecksum>
  11. <SpellDef InternalName="BasicBowAttack">
  12. <DisplayName>Bow Attack</DisplayName>
  13. <Description>Attack a unit from a distance with a single arrow from your bow.</Description>
  14. <Image>Action_BowArrow.png</Image>
  15. <IconFG>Action_BowArrow.png</IconFG>
  16. <IconBG>Action_BowArrow.png</IconBG>
  17. <IconColor>255,255,255</IconColor>
  18. <Range>2.0</Range>
  19. <ManaCost>0</ManaCost>
  20. <MoveCost>10</MoveCost>
  21. <SpellType>Strategic</SpellType>
  22. <SpellClass>Offensive</SpellClass>
  23. <IsRangedAttack>1</IsRangedAttack>
  24. <SpellTargetType>EnemyUnit</SpellTargetType>
  25. <ValidTerrainCategory>Land</ValidTerrainCategory>
  26. <ValidTerrainCategory>Beach</ValidTerrainCategory>
  27. <ValidTerrainCategory>Forest</ValidTerrainCategory>
  28. <ValidTerrainCategory>City</ValidTerrainCategory>
  29. <ValidTerrainCategory>Water</ValidTerrainCategory>
  30. <ValidTerrainCategory>Cliff</ValidTerrainCategory>
  31. <ValidTerrainCategory>Mountain</ValidTerrainCategory>
  32. <GameModifier InternalName="ArrowDamage">
  33. <ModType>Unit</ModType>
  34. <Attribute>DefendableDamage</Attribute>
  35. <!-- Use the unit's attack stat to determine damage done by the arrow -->
  36. <Calculate InternalName = "Value" ValueOwner="CastingUnit">
  37. <Expression><![CDATA[[UnitStat_Attack]*1]]></Expression>
  38. </Calculate>
  39. <Calculate InternalName = "MinValue">
  40. <Expression><![CDATA[[Value]*.2]]></Expression>
  41. </Calculate>
  42. <Calculate InternalName = "MaxValue">
  43. <Expression><![CDATA[[Value]*1]]></Expression>
  44. </Calculate>
  45. </GameModifier>
  47. <SpellCastEffectName>Arrow</SpellCastEffectName>
  48. <SpellCastEffectScale>0.50</SpellCastEffectScale>
  49. <SpellCastProjectile>1</SpellCastProjectile>
  50. <SpellCastProjectileSpeed>750</SpellCastProjectileSpeed>
  51. <SoundFX>Hit_Arrow1</SoundFX>
  52. <SoundFX>Hit_Arrow2</SoundFX>
  53. </SpellDef>
  56. </Spells>