Derek: thanks for your reply! The Veteran and Experienced traits work fine before you save and exit. But once you save and exit (even once), the traits never work again, ever, for the current game. There is nothing hit and miss about it. This bug is 100% reproducible. I will try to post screen shots and saved game further down this thread (first time trying this for me).
Note that it is entirely possible to have one unit with a functional Veteran trait (created before saving and exiting for the first time) and another unit with a failed Veteran (or Experienced) trait from later in the game (created after saving and exiting for the first time).
Hope these can be fixed, or if not removed from the palette of traits.
Custom unit design is one of the great features of this superb strategy game. FE and LH are classics for sure and take up most of my gaming time these days. Well done.